do not remove __typename from input values #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-router-docs canceled.
|
This comment has been minimized.
This comment has been minimized.
Geal
changed the title
added 2 commits
April 26, 2022 14:57
to avoid copies, response formatting removes element from the input
value to add them to the output value. In the case of __typename though,
if it is explicitely requested by the client, it should not be removed
because it might be used in a fragment later.
Example:
query {
get {
__typename
... on Product {
symbol
}
}
}
if __typename is removed from input values, it won't be usable in the
fragment spread to check that the type is Product
Geal
changed the title
bnjjj
reviewed
Apr 26, 2022
bnjjj
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #899
For now, there's only a unit test reproducing the issue