Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unskipped fields at the root of the selection set #930 #931

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Apr 28, 2022

close #930

I also added support of fed2 for fuzz targets, because we used fed1 before, it's better to target fed2.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
@bnjjj bnjjj requested a review from Geal April 28, 2022 15:49
@bnjjj bnjjj self-assigned this Apr 28, 2022
@netlify
Copy link

netlify bot commented Apr 28, 2022

Deploy Preview for apollo-router-docs ready!

Name Link
🔨 Latest commit ceafade
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/626b9f42ff3f230008f2c9d1
😎 Deploy Preview https://deploy-preview-931--apollo-router-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions

This comment has been minimized.

Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

apollo-router-core/src/spec/query.rs Outdated Show resolved Hide resolved
docker-compose-federation2.yml Show resolved Hide resolved
NEXT_CHANGELOG.md Outdated Show resolved Hide resolved
docker-compose-federation2.yml Show resolved Hide resolved
bnjjj and others added 2 commits April 29, 2022 10:17
Co-authored-by: Gary Pennington <gary@apollographql.com>
Co-authored-by: Jeremy Lempereur <jeremy.lempereur@gmail.com>
@bnjjj bnjjj requested a review from garypen April 29, 2022 08:18
@bnjjj bnjjj enabled auto-merge (squash) April 29, 2022 13:15
@bnjjj bnjjj merged commit 69833be into main Apr 29, 2022
@bnjjj bnjjj deleted the bnjjj/fix_930 branch April 29, 2022 13:43
@BrynCooke BrynCooke added this to the v0.1.0-preview.7 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug on repeated fields with different skip and include directive value
5 participants