Skip to content

Move layers into consistent locations, add documentation. #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 3, 2022

Conversation

BrynCooke
Copy link
Contributor

@BrynCooke BrynCooke commented May 3, 2022

No code changes, just moved things around and added docs.

Document layers

Document the notable existing layers and add rust docs for custom layers including basic use cases.

Layer cleanup

Reusable layers have all been moved to apollo_router_core::layers. In particular the checkpoint_* layers have been moved from the plugins module.
Layers that were internal to our execution pipeline have been moved and made private to the crate.

@netlify
Copy link

netlify bot commented May 3, 2022

Deploy Preview for apollo-router-docs canceled.

Name Link
🔨 Latest commit 1618536
🔍 Latest deploy log https://app.netlify.com/sites/apollo-router-docs/deploys/62710d389a4c6f0008808f80

@github-actions

This comment has been minimized.

@BrynCooke BrynCooke linked an issue May 3, 2022 that may be closed by this pull request
@BrynCooke BrynCooke changed the title Move layers into consistent locations Move layers into consistent locations, add documentation. May 3, 2022
Fix compile error.
@BrynCooke BrynCooke force-pushed the bryn/move-layers branch from fda161d to 1618536 Compare May 3, 2022 11:08
@BrynCooke BrynCooke marked this pull request as ready for review May 3, 2022 11:16
@BrynCooke BrynCooke requested a review from StephenBarlow as a code owner May 3, 2022 11:16
Copy link
Contributor

@o0Ignition0o o0Ignition0o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid work, gg! 🎉

@BrynCooke BrynCooke merged commit 5b32cc2 into main May 3, 2022
@BrynCooke BrynCooke deleted the bryn/move-layers branch May 3, 2022 14:44
@BrynCooke BrynCooke added this to the v0.1.0-preview.7 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document service builder methods
3 participants