Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sometimes the leader rover dev session thinks it's a follower #1295

Closed
EverlastingBugstopper opened this issue Sep 8, 2022 · 0 comments
Closed

sometimes the leader rover dev session thinks it's a follower #1295

EverlastingBugstopper opened this issue Sep 8, 2022 · 0 comments
Assignees
@EverlastingBugstopper
Labels
bug 🐞
Milestone
rover dev

Comments

@EverlastingBugstopper
Copy link
Contributor

this seems to only happen on MacOS - we can circumvent this issue by re-using the is_main_session boolean that is determined at startup and also by removing the socket file when the main rover dev session is killed
@EverlastingBugstopper EverlastingBugstopper added this to the rover dev milestone Sep 8, 2022
@EverlastingBugstopper EverlastingBugstopper self-assigned this Sep 8, 2022
Merged
EverlastingBugstopper added a commit that referenced this issue Sep 8, 2022
@EverlastingBugstopper
fix: harden router spawner/killer (#1293)
cd6dada 
This PR fixes #1294 and #1295.

there were some issues on MacOS related to leader/follower socket
addresses that are fixed now, and we also hardened the router killer by
waiting for the health check to start failing before shutting down the
`rover dev` process
Merged
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
bug 🐞
Projects
None yet
Milestone
rover dev
Development

No branches or pull requests
1 participant
@EverlastingBugstopper