-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on routing url option #169
Comments
What I wrote to @JakeDawkins was that in my ideal world, this is what things would look like. If @JakeDawkins had the following to say
I like this a lot ^^
I kinda like this because if they intend on using managed federation, this would be helpful to them
I don’t see that really being necessary. Especially since it’d probably require a query on our end first to see what the url is, and even then it technically could change between the first query and the mutation to update. Unless of course, we ask for this info in the response. I just don’t think it has a ton of tangible value
This also seems unnecessary, since I imagine changing the url is a very common thing rather than a breaking dangerous thing. I think --force makes it feel like “You shouldn’t do this, but we’ll allow it if you’re sure” |
Re-reading this, I think I stand by my proposal despite @JakeDawkins' comments, with the exception of "emit a warning if By default, upsert, and require a Perhaps the Gravity folks have thought about this a bit more with Launch Control though and we should solicit input from their end. |
related to #121 |
ssssoooo, i feel kinda dumb now since the API already handles this pretty much exactly! opening a pr shortly |
Related to changes introduced in #130
TODO (jake) -- fill in details here
The text was updated successfully, but these errors were encountered: