Add subgraph push option to specify endpoint
#130
Conversation
JakeDawkins
requested review from
EverlastingBugstopper and
lrlna
as code owners
JakeDawkins
added
feature 🎉
JakeDawkins
force-pushed
the
jake/push-url
branch
from
602751c
to
05dcc8e
Compare
| (https://www.apollographql.com/docs/federation/managed-federation/overview/). If | ||
| You're running a service which hasn't been deployed yet or isn't using managed | ||
| federation, you may pass a placeholder url or leave the flag empty | ||
| (i.e. `--routing-url=""`). |
There was a problem hiding this comment.
This seems like something that would benefit from some guidance in Rover itself.
I propose that if they pass a --routing-url to a subgraph push invocation that doesn't need it (in the case of a non-deployed service, or unmanaged federation), Rover should return an error that lets them know that what they passed won't be used. I think this approach would eliminate some of the confusion our users may have about the usage of the flag.
There was a problem hiding this comment.
I actually think I missed Josh's original comment here (or just forgot since it's been a while), but it seems valuable here:
If they are pushing partial schemas to the registry then it will be managed federation. Unmanaged federation doesn't go through the registry.
Unmanaged federation directly get the subgraph schemas by querying the urls at runtime and fetching them via introspection and composing it directly in the gateway. The registry is bypassed in this mode.
If this is the case, then perhaps we don't need to mention unmanaged federation in this section of the docs? Perhaps my confusion is coming from the suggestion of the --routing-url="" here
There was a problem hiding this comment.
@EverlastingBugstopper There's no way for the registry or rover to know if a gateway is running in managed federation mode though unfortunately.
Managed federation is chosen at runtime on the gateway. it's just a matter of where the gateway is getting its config from: either a list of service urls or from studio. So there's no way for us to figure this out here
There was a problem hiding this comment.
We could make this flag optional, but it's not optional in the API. So we'd have to pass the empty string through to studio anyway
| /// (often a deployed service). May be left empty ("") or a placeholder url | ||
| /// if not running a gateway in managed federation mode | ||
| #[structopt(long)] | ||
| routing_url: String, |
There was a problem hiding this comment.
We should probably parse this in as a Url instead of a String.
There was a problem hiding this comment.
We could do this, but we'd have to make the flag optional in that case, so we have the ability to omit it.
|
It seems that the flag has been added to Rover's API surface in addition to docs (🥳 ), but I don't actually see any changes to |
This is just an implementation with a placeholderpublic_urluntil we land on a concrete name in #129Updated the name to
routing-url