Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider an alternative to "N/A" in rover subgraph list #483

Closed
abernix opened this issue Apr 28, 2021 · 7 comments · Fixed by #505
Closed

consider an alternative to "N/A" in rover subgraph list #483

abernix opened this issue Apr 28, 2021 · 7 comments · Fixed by #505
Assignees
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Milestone

Comments

@abernix
Copy link
Member

abernix commented Apr 28, 2021

Description

Perhaps rather than showing that the Routing Url is "N/A" (Not available), which makes it sound like it's not available (for some transient reason), we should state that it's "Unspecified" or "Not defined"? Happy to open a PR!

let url = subgraph.url.clone().unwrap_or_else(|| "N/A".to_string());

Screen Shot 2021-04-28 at 19 37 43

@abernix abernix added feature 🎉 new commands, flags, functionality, and improved error messages triage issues and PRs that need to be triaged labels Apr 28, 2021
@EverlastingBugstopper
Copy link
Contributor

i like the "unroutable" that you mentioned in slack, but unspecified also works here

@lrlna
Copy link
Member

lrlna commented May 3, 2021

Unroutable makes me think that something is wrong with my subgraph and its routing. I do like unspecified though!

@JakeDawkins
Copy link
Contributor

+1 for unspecified

@lrlna lrlna added this to the May 11 - GA milestone May 3, 2021
@EverlastingBugstopper
Copy link
Contributor

Unroutable makes me think that something is wrong with my subgraph and its routing. I do like unspecified though!

This is true though, correct? If your URL is an empty string, we're pretty sure that the graph router will not be able to route any requests at all to that subgraph. Even though it's a technically allowed state, that subgraph truly is unroutable.

I'm still OK with unspecified here but want to make sure I'm on the same page about what this state actually means for folks.

@abernix
Copy link
Member Author

abernix commented May 4, 2021

I think @EverlastingBugstopper's take is right, but I suppose there are cases (e.g., a mocked graph? Perhaps something in Workbench?) where Un-routable is too heavy/scary and unspecified is better?

Curious what @ndintenfass thinks here.

@EverlastingBugstopper
Copy link
Contributor

decision: unspecified

@abernix
Copy link
Member Author

abernix commented May 5, 2021

Okay, unspecified.

@abernix abernix self-assigned this May 5, 2021
abernix added a commit that referenced this issue May 5, 2021
This changes the text from "N/A" (which often means "not available", and
somewhat sounds like we don't have access to it) to "unspecified" (which is
what it is; this is what it is though represented by `null` in the DB).

Closes #483
abernix added a commit that referenced this issue May 5, 2021
This changes the text from "N/A" (which often means "not available", and
somewhat sounds like we don't have access to it) to "unspecified" (which is
what it is; this is what it is though represented by `null` in the DB).

Closes #483
EverlastingBugstopper pushed a commit that referenced this issue May 5, 2021
This changes the text from "N/A" (which often means "not available", and
somewhat sounds like we don't have access to it) to "unspecified" (which is
what it is; this is what it is though represented by `null` in the DB).

Closes #483
@abernix abernix removed the triage issues and PRs that need to be triaged label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants