Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error for introspection unreachable endpoint #489

Closed
EverlastingBugstopper opened this issue Apr 29, 2021 · 1 comment · Fixed by #518
Closed

better error for introspection unreachable endpoint #489

EverlastingBugstopper opened this issue Apr 29, 2021 · 1 comment · Fixed by #518
Assignees
Labels
Milestone

Comments

@EverlastingBugstopper
Copy link
Contributor

if you try to rover subgraph introspect http://localhost:4000 when it's not running, you should get a semi-nice error message instead of what we currently send which is this:

error: encountered an error while sending a request
        This error was unexpected! Please submit an issue with any relevant details about what you were trying to do: https://github.com/apollographql/rover/issues/new

this error is a bit heavy handed so we should likely fix it up in other places it might appear as well

@lrlna
Copy link
Member

lrlna commented May 3, 2021

Ohhhh, Adding this to May 11. This should be a quick fix, and would be good to be done for GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants