feat: RoverClientError::CouldNotConnect #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
added
the
feature 🎉
Comment on lines
+78
to
+82
| if let Some(url) = .url { | ||
| url.to_string() | ||
| } else { | ||
| "Unknown URL".to_string() | ||
| } |
There was a problem hiding this comment.
pretty friggin neat if i do say so myself
| /// Encountered an error sending the request. | ||
| #[error("encountered an error while sending a request")] | ||
| #[error(transparent)] |
There was a problem hiding this comment.
i changed this to transparent so that it would just print out the whole error message from reqwest. they're a bit verbose but they at least give some info to the user that we were obfuscating previously. i imagine as we see these crop up we can add more of our own error types
src/error/metadata/suggestion.rs
Outdated
| @@ -115,6 +116,7 @@ impl Display for Suggestion { | |||
| ) | |||
| } | |||
| Suggestion::Adhoc(msg) => msg.to_string(), | |||
| Suggestion::CheckServerConnection => "Make sure the endpoint is accepting connections.".to_string() | |||
There was a problem hiding this comment.
don't love this wording. if anybody has suggestions 😉 lemme know
EverlastingBugstopper
force-pushed
the
avery/better-introspect-error
branch
2 times, most recently
from
89a9475
to
8b0bea0
Compare
EverlastingBugstopper
force-pushed
the
avery/better-introspect-error
branch
from
8b0bea0
to
36f3037
Compare
lrlna
approved these changes
May 7, 2021
Comment on lines
+78
to
+82
| if let Some(url) = .url { | ||
| url.to_string() | ||
| } else { | ||
| "Unknown URL".to_string() | ||
| } |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #489
before:
after:
other HTTP request related errors now just use the default reqwest formatting, and provides no suggestion. we can incrementally improve this as time goes on.
couple fun new patterns here for intelligent error handling in this PR. This error currently applies to any request made by rover-client, not just introspection. folks might see this error if Studio ever starts refusing incoming TCP connections. Most folks will run into this when running introspection on an invalid endpoint. I'm wondering if this catch-all approach is good here (returning this error type on every request made by rover-client where the server refuses a connection) or if we should try to provide more granular info based on the command they're running or if the Url it can't connect to is supplied by the user vs. one that we coded.