introspect drops comment new lines which breaks SDL parsing

[stephenh]

We had an SDL file on our server-side that looked like:

"""
I.e. "an example value"
"""
type Foo { ... }

However rover graph introspect turned this into:

"""I.e. "an example value""""
type Foo { ... }

Which then causes graphql-js's lexer.js to blow up on "unterminated string", i.e. it doesn't like the quadruple quotes.

Perhaps this is really a bug in graphql-js's parsing? Being some lazy and filing it here because we found it via rover introspect changing the SDL (or maybe that is also happening inside of graphql-js, I'm not sure).

I can re-file this with the graphql-js project if that's where the error really is. Thanks!

[ericf89]

Seeing this too with a description that terminates in a double quote. 🤔

It's inlined, and makes it so this schema can't be parsed by a rover graph check command later in our pipeline

Interestingly, whatever process that publishes the sdl to apollo studio on startup seems to be sending/parsing this correctly

On the server being introspected, we're running apollo-server@3.1.2 and graphql-js@15.5.1

graphql/graphql-js#1205 in graphql-js seems related but already solved/closed

[lrlna]

@stephenh @ericf89 thank you for reporting this. That definitely seems like a bug in our encoder that ought to be fixed!

[lrlna]

@stephenh @ericf89 the fix will be part of our next release. I can ping you once it's out.

[ericf89]

Thanks for the quick turn around @lrlna!