Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): reduce introspection timeouts + spawn/kill process _groups_ #1233

Merged

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Aug 11, 2022

this PR fixes #1219 and #1230

  • when spawning processes, spawn them into a process group instead of just a process. now, when we kill processes, it actually... kills the processes. before, if npm run start spawns nodemon and nodemon spawns node index.js, only the npm process would be killed. now they are all killed.
  • set the introspection timeout to 2 seconds instead of 30 seconds when scanning your local network.

@EverlastingBugstopper EverlastingBugstopper changed the title wip: better process cleanup fix(dev): reduce introspection timeouts + spawn/kill process _groups_ Aug 12, 2022
@EverlastingBugstopper EverlastingBugstopper merged commit 66a1c19 into avery/alt-subgraph-dev Aug 12, 2022
@EverlastingBugstopper EverlastingBugstopper deleted the avery/fix-process-cleaner branch August 12, 2022 16:16
@EverlastingBugstopper EverlastingBugstopper mentioned this pull request Aug 12, 2022
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant