Show a better message when a subgraph is published with no changes #1757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
rover subgraph publish
is run but there are no changes to the schema or routing URL, the publish mutation will succeed but nothing is actually changed related to the subgraph and a build/launch is never created. We indicate that this is the case by sending backwasUpdated: false
but rover is not currently using that field (and it's not even exposed via the platform-api). This has caused some confusion because when customer's see the "the subgraph has was updated" message they think that something must have gone wrong during composition. This can be reproduced by simply running a subgraph publish twice for the same schema and URL:This PR updates the message shown after the second publish above so that it would instead say:
This was tested by using:
On my staging graph and repeating it with no changes, then repeating it again after making a change to the schema.