🐛 Use proposalCoverage in addition to severityLevel to build correct proposal check messaging #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oposal check messaging
cy
approved these changes
Feb 9, 2024
…to-use-proposalCoverage-field
…to-use-proposalCoverage-field
o0Ignition0o
approved these changes
Feb 20, 2024
…to-use-proposalCoverage-field
abernix
approved these changes
Feb 20, 2024
…to-use-proposalCoverage-field
o0Ignition0o
deleted the
swcollard/proposal-checks/correct-messaging-to-use-proposalCoverage-field
branch
Merged
Geal
added a commit
that referenced
this pull request
Mar 26, 2024
## 🚀 Features - **Add `--no-url` shorthand to `subgraph publish` - @lennyburdette PR #1809** This is slightly more convenient and less awkward than `--routing-url "" --allow-invalid-routing-url` - **Support unix socket URLs - @Geal PR #1879** Since its [1.43.0 release](https://github.com/apollographql/router/releases/tag/v1.43.0), the Router can now connect to subgraph over unix sockets. This removes a warning when publishing a schema with a `unix://` URL. ## 🐛 Fixes - **Use task specific `rayon` threadpools and not the global threadpool - @garypen PR #1872** This increases rover's reliability by executing independent tasks in different thread pools. - **Prevent an infinite loop when restarting the router - @Geal PR #1855** When restarting a Router on schema updates, it could happen that an internal task of Rover would go in an infinite loop and consume CPU needlessly. This is now fixed and should make `rover dev` more reliable. - **Use `proposalCoverage`` in addition to `severityLevel`` to build correct proposal check messaging - @swcollard PR #1845** This updates the message on proposal checks depending on the `proposalCoverage` field ## 🛠 Maintenance - **Upgrade axios to address a security warning - @goto-bus-stop PR #1819** The vulnerability didn't affect rover, but now you won't get a warning for it! - **Remove yanked online check - @dylan-apollo PR #1803** ## 📚 Documentation - **Update dev docs about which Router version is used - @smyrick PR #1822** - **Update warning about `federation_version` in `rover compose` - @smyrick, @Meschreiber PR #1806** - **Document how to use `subgraph fetch` with proposals - @Meschreiber PR #1823** --------- Co-authored-by: Geoffroy Couprie <apollo@geoffroycouprie.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received a bug report of rover displaying the message,
Your check failed because some or all of the diffs in this change are not in an approved Proposal.for a check response that in fact was passing because all the diffs in the Check were related to an approved Proposal.This is because the messaging is keying off of solely the configured value,
severityLeveland not theproposalCoveragefield which indicates the detailed results of a check task.Changes
This PR changes how we calculate that message to take
proposalCoverageinto account, and usesseverityLevelto match the message in the failing case.Testing Locally
Did some local testing and here are a few example scenarios
Severity level set to ERROR, missing approvals
Severity level set to WARN, missing approvals
Severity level set to WARN, only partial approval
Fully approved and passing