Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pnpm installs by moving binary download location #1927

Merged
merged 3 commits into from
Jun 17, 2024

Commits on Jun 15, 2024

  1. Add new CI check to ensure we can install under JS

    We ended up breaking stuff in v0.23.0 because of
    changes to the libraries used, this allows us to
    both:
    
    - See if this ever happens again
    - Prove we've actually fixed the problem
    jonathanrainer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    8ca5b51 View commit details
    Browse the repository at this point in the history
  2. Install binaries to a /binary folder

    Instead of installing to a location relative to the `binary.js` file,
    which leaves us open to problems due to how package managers may
    choose to work, use a /binary folder at the same level as the `package.json`
    instead.
    jonathanrainer committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    44a126c View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Fixing up nits

    jonathanrainer committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    2e0caea View commit details
    Browse the repository at this point in the history