fix(telemetry): don't report usage data for dev builds #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
|
Is there any practical reason to have telemetry in non-release builds, aside from checking that we don't break telemetry between releases? Because if there's no super compelling reason, I feel like it'd be easier to just not report in non-release builds. I know I usually run with it disabled on my machine, so it'd at least save that step :) edit: I hope that comment didn't sound blunt. haha just trying to weigh the cost/benefits here :wendyparrot: |
|
mmm-no, not really! happy to just turn it off completely - lets just do that edit: no, not too blunt, i think you're right 😉 |
EverlastingBugstopper
force-pushed
the
avery/report-dev-builds
branch
from
9e3adee
to
f014e92
Compare
EverlastingBugstopper
force-pushed
the
avery/report-dev-builds
branch
from
f014e92
to
2382b67
Compare
EverlastingBugstopper
changed the title
EverlastingBugstopper
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should let us differentiate between our CI test suite/dev machines and our users executions. right now our charts are skewed pretty heavily by our test runners!
an alternative solution would be to pass a separate field entirely that lets us know if we're running a dev version. we could also just disable telemetry entirely for non-release builds! let me know what y'all think the best approach would be.
looks like npm 7 included some package.json changes here as well