Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds useful info to logs #268

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Feb 12, 2021

  • environment variables print with values when accessed
    do not print at all if they do not exist

  • each response from rover-client is logged

  • some misc. refactors/cleanup associated with the above changes

Before

Feb 12 13:21:00.503 DEBUG rover::utils::env: reading APOLLO_CONFIG_HOME
Feb 12 13:21:00.503 DEBUG rover::utils::env: reading APOLLO_KEY
Feb 12 13:21:00.504 DEBUG rover::utils::env: reading APOLLO_TELEMETRY_DISABLED
Feb 12 13:21:00.504 DEBUG rover::utils::env: reading APOLLO_TELEMETRY_URL
Feb 12 13:21:00.504 DEBUG rover::utils::env: reading APOLLO_REGISTRY_URL
Feb 12 13:21:00.504 DEBUG rover::utils::env: reading APOLLO_CONFIG_HOME
Feb 12 13:21:00.504 DEBUG rover::utils::env: reading APOLLO_KEY
Feb 12 13:21:00.510 DEBUG rover::utils::env: reading APOLLO_VCS_BRANCH
Feb 12 13:21:00.510 DEBUG rover::utils::env: reading APOLLO_VCS_COMMIT
Feb 12 13:21:00.510 DEBUG rover::utils::env: reading APOLLO_VCS_COMMITTER
Feb 12 13:21:00.511 DEBUG rover::utils::env: reading APOLLO_VCS_REMOTE_URL
Feb 12 13:21:00.515 DEBUG houston::profile: APOLLO_KEY=Some("user******************oUPA")

After

Feb 12 13:20:19.555 DEBUG rover::utils::env: read environment variable $APOLLO_KEY = user******************oUPA
Feb 12 13:20:19.577 DEBUG houston::profile: using API key user******************oUPA   
Feb 12 13:20:19.873 DEBUG rover_client::blocking::client: {"data":{"frontendUrlRoot":"https://studio.apollographql.com","service":{"implementingServices":{"__typename":"FederatedImplementingServices","services":[{"name":"people","url":"","updatedAt":"2020-12-18T18:25:44.844Z"},{"name":"films","url":"","updatedAt":"2020-12-18T18:26:10.961Z"}]}}}}

Copy link
Contributor

@JakeDawkins JakeDawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉 🎉

crates/rover-client/src/blocking/client.rs Show resolved Hide resolved
crates/rover-client/src/blocking/client.rs Show resolved Hide resolved
- environment variables print with values when accessed
do not print at all if they do not exist

- each response from rover-client is logged

- some misc. refactors/cleanup associated with the above changes
@EverlastingBugstopper EverlastingBugstopper merged commit 25d4ba9 into main Feb 15, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/improve-logs branch February 15, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants