Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prettier table #315

Merged
merged 1 commit into from
Mar 1, 2021
Merged

feat: prettier table #315

merged 1 commit into from
Mar 1, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

before:

$ rover subgraph list averys-federated-graph
Listing subgraphs for averys-federated-graph@current using credentials from the default profile.
+--------+-------------+----------------------------+
| Name   | Routing Url | Last Updated               |
+--------+-------------+----------------------------+
| films  | N/A         | 2020-12-18 12:26:10 -06:00 |
+--------+-------------+----------------------------+
| people | N/A         | 2020-12-18 12:25:44 -06:00 |
+--------+-------------+----------------------------+

View full details at https://studio.apollographql.com/graph/averys-federated-graph/service-list

after:

$ rover subgraph list averys-federated-graph
Listing subgraphs for averys-federated-graph@current using credentials from the default profile.
┌────────┬─────────────┬────────────────────────────┐
│  Name  │ Routing Url │        Last Updated        │
├────────┼─────────────┼────────────────────────────┤
│ films  │ N/A         │ 2020-12-18 12:26:10 -06:00 │
├────────┼─────────────┼────────────────────────────┤
│ people │ N/A         │ 2020-12-18 12:25:44 -06:00 │
└────────┴─────────────┴────────────────────────────┘

View full details at https://studio.apollographql.com/graph/averys-federated-graph/service-list

@EverlastingBugstopper EverlastingBugstopper added the feature 🎉 new commands, flags, functionality, and improved error messages label Feb 26, 2021
@EverlastingBugstopper EverlastingBugstopper added this to the March 9 milestone Feb 26, 2021
@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/cute-table branch 2 times, most recently from 5836d2d to f7331bb Compare February 26, 2021 18:07
JakeDawkins
JakeDawkins suggested changes Feb 26, 2021
View reviewed changes
src/command/graph/check.rs Show resolved Hide resolved
src/command/graph/check.rs Outdated Show resolved Hide resolved
JakeDawkins
JakeDawkins approved these changes Mar 1, 2021
View reviewed changes
src/command/graph/check.rs
table.add_row(row!["Change", "Code", "Description"]);
let mut table = table::get_table();

// bc => sets top row to be bold and center
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The added comments are perfect :) I imagine most of the time this will be copy/pasted anyway!

@EverlastingBugstopper EverlastingBugstopper merged commit 1e43488 into main Mar 1, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/cute-table branch March 1, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeDawkins JakeDawkins JakeDawkins approved these changes

@lrlna lrlna Awaiting requested review from lrlna

Assignees
No one assigned
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Milestone
March 9
Development

Successfully merging this pull request may close these issues.
2 participants
@EverlastingBugstopper @JakeDawkins