feat: check for available updates #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeDawkins
added
the
feature 🎉
JakeDawkins
requested review from
EverlastingBugstopper and
lrlna
as code owners
JakeDawkins
force-pushed
the
jake/updateeeeeeee-pleas
branch
from
327f659
to
0361f50
Compare
src/utils/version.rs
Outdated
Comment on lines
66
to
69
| "There is a newer version of Rover available for download: {} (currently running v{})\n\nFor instructions on how to install the latest version of Rover, see {}", | ||
| Cyan.normal().paint(format!("v{}", latest)), | ||
| PKG_VERSION, | ||
| Cyan.normal().paint("https://go.apollo.dev/r/start") |
There was a problem hiding this comment.
Suggested change
| "There is a newer version of Rover available for download: {} (currently running v{})\n\nFor instructions on how to install the latest version of Rover, see {}", | |
| Cyan.normal().paint(format!("v{}", latest)), | |
| PKG_VERSION, | |
| Cyan.normal().paint("https://go.apollo.dev/r/start") | |
| "There is a newer version of Rover available for download: {} (currently running v{})\n\nFor instructions on how to install the latest version of Rover, run {}", | |
| Cyan.normal().paint(format!("v{}", latest)), | |
| PKG_VERSION, | |
| Yellow.normal().paint("`rover docs open start`") |
src/error/metadata/mod.rs
Outdated
| @@ -71,6 +71,7 @@ impl From<&mut anyhow::Error> for Metadata { | |||
| } | |||
| RoverClientError::InvalidKey => (Some(Suggestion::CheckKey), None), | |||
| RoverClientError::MalformedKey => (Some(Suggestion::ProperKey), None), | |||
| RoverClientError::UnparseableReleaseVersion => (None, None), | |||
There was a problem hiding this comment.
seems like this should maybe be one of the "file an issue" suggestions, what do you think?
EverlastingBugstopper
approved these changes
Mar 1, 2021
|
looking good! if we wanted to get fancy on it we could wrap that version update text in one of my fancy Billboards (should use what's on the latest branch there, i've changed the api a bit and haven't published quite yet) |
Definitely! I forgot about that :) And that'd make the message stand out a lot more, so hopefully it wouldn't be missed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #296
I added a util
versionmodule that can be called from the root of the cli (in therunfn) or from therover update checkcommand.I kept the interaction with GitHub and the network requests in
rover-clienteven though it's not graphql :)Logging was a bit of a weird question, so I used
eprintlninside the check fn, not inside their calling commands. Happy to hear other recommendations though!