Add version defaults to install scripts #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88
Description
This PR changes the two install scripts to behave similarly to each other, each taking the best parts of the other to provide a friendly and intuitive install process for rover :)
Windows changes
Old Behavior
The old installer script only had the ability to download the version it was released with, i.e. the installer released with 0.0.2 could only install rover 0.0.2.
New Behavior
By default, if no
VERSION
env variable is present, the windows install script will install the version of Rover the corresponding script was released with, similar to before.The change here is you can now use the
$Env:VERSION
env variable to override the default version, and download another version of the Rover binary.Old Behavior
The old installer could only install the rover version defined by the
VERSION
env variable.New Behavior
By default, if no
VERSION
env variable is present, the nix install script will install the version of Rover the corresponding script was released with. Passing theVERSION
env variable overrides the default version, and downloads another version of the Rover binary.No VERSION env variable is needed when executing the script anymore.
Fun notes
0.0.3
, for example, always would've been installing the latest version (which we definitely would have heard about)