Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

push -> publish #347

Merged
merged 4 commits into from
Mar 17, 2021
Merged

push -> publish #347

merged 4 commits into from
Mar 17, 2021

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Mar 16, 2021 •
edited
Loading

Fixes #344

This PR is broken up by 3 commits for each of the following respectively:

  • update naming for all the public-facing commands/help texts
  • update internal references to push (i.e. rover-client)
  • update docs with publish

@JakeDawkins JakeDawkins added BREAKING ❗ a PR that represents a breaking change docs 📝 improvements or additions to docs on the docs site maintenance 🛠️ labels Mar 16, 2021
EverlastingBugstopper
EverlastingBugstopper approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :) thanks for taking care of this. we'll want to make sure we call out that this is a breaking change in our changelog for sure.

@JakeDawkins JakeDawkins merged commit 6267e2b into main Mar 17, 2021
@JakeDawkins JakeDawkins deleted the jake/publish branch March 17, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper approved these changes

@lrlna lrlna Awaiting requested review from lrlna

@StephenBarlow StephenBarlow Awaiting requested review from StephenBarlow

Assignees
No one assigned
Labels
BREAKING ❗ a PR that represents a breaking change docs 📝 improvements or additions to docs on the docs site maintenance 🛠️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename: change "push" to "publish"
2 participants
@JakeDawkins @EverlastingBugstopper