chore: add retries with backoff to schema download #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
JakeDawkins
approved these changes
Mar 24, 2021
|
i wish |
|
this feels reasonable |
| let max_delay_secs = 30; | ||
| let mut has_failed = false; | ||
|
|
||
| loop { |
There was a problem hiding this comment.
rather than manually reimplementing this retry logic, might just want to use the retry crate as per here: https://github.com/getditto/ditto/blob/develop/hydra/hydra-common/src/transaction_log.rs#L76. we've already incurred the dependency via hydra-common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generally nice to have, might fix the spurious errors we're seeing in CI