Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(binstall): remove binary before overwriting it #400

Merged
merged 1 commit into from
Mar 31, 2021
Merged

chore(binstall): remove binary before overwriting it #400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions installers/binstall/src/install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ impl Installer {
let bin_path = self.get_bin_path()?;
tracing::debug!("copying from: {}", &self.executable_location);
tracing::debug!("copying to: {}", &bin_path);
// attempt to remove the old binary
// but do not error if it doesn't exist.
let _ = fs::remove_file(&bin_path);
fs::copy(&self.executable_location, &bin_path)?;
Ok(())
}
Expand Down