-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error codes #457
Merged
Merged
Add error codes #457
Changes from 21 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
eadeff5
add some meaningless codes real quik
JakeDawkins 1999bdc
rough explain command and md generation
JakeDawkins 02a1db3
Update src/command/explain.rs
JakeDawkins 001816c
add markdown formatting to code explanations
JakeDawkins 1027b21
use strum to convert from str -> enum
JakeDawkins 95b0a7c
lint
JakeDawkins 0bddcbe
Merge branch 'main' into jake/error-codes-coding-errors-code
JakeDawkins 6bf602d
allow uppercase acronyms for EALL
JakeDawkins 9f3df62
remove code for adhoc error
JakeDawkins f42b2d9
Merge branch 'main' into jake/error-codes-coding-errors-code
JakeDawkins 005f60e
remove md link replacing
JakeDawkins c3eec10
update string allocation
JakeDawkins d1c7f61
Merge branch 'jake/error-codes-coding-errors-code' of github.com:apol…
JakeDawkins 2271d2e
first batch of error descriptions
JakeDawkins 460e54a
update messages
JakeDawkins a1f8860
update error code descriptions
JakeDawkins 45cd14b
build error reference in build.rs
JakeDawkins 88aaa32
remove EALL
JakeDawkins 2438982
lint
JakeDawkins 65241bb
Merge branch 'main' into jake/error-codes-coding-errors-code
JakeDawkins eb97d02
update changelog
JakeDawkins b9e9f1a
remove unused error code
JakeDawkins e544da1
update error message
JakeDawkins d36fc59
update code numbers
JakeDawkins 4c2694c
Merge branch 'main' into jake/error-codes-coding-errors-code
JakeDawkins 2c7e8d6
add error code for composition failure
JakeDawkins 8cbfe0a
update error docs
JakeDawkins 662d1fb
Merge branch 'main' into jake/error-codes-coding-errors-code
lrlna 62296a7
add E028
lrlna c93f47c
Create E028.md
lrlna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we maybe error here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We definitely could 🤷♂️ Especially since this is at buildtime. I just left it as the simpler option in the meantime. Do you think I should change that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah since it's at build time i think maybe we should error here so we don't commit something that doesn't work, i imagine filtering out the errors could end up with some head scratches if something goes wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to keep this as is for now and we can get it to error in an xtask refactor.