-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph/subgraph misusage errors #459
Conversation
What I'd love to see for rover is the following happy path, assuming create a new subgraph: publish a new schema without updating the routing url: publish a new schema AND update the routing url -- If you tried to -- If you tried to |
@lrlna I think we agreed we wanted to add a flag to confirm the conversion from monolith to federated graph. For monolithic graphs or variants with nothing pushed to it, we didn't want to force someone to confirm the change, since it's not destructive of anything. But for existing monoliths, we did want them to confirm with a flag We said this would take a quick roundtrip to the API to see if the graph was federated to begin with. Probably using the I hope this makes sense :) |
4021ee1
to
235c602
Compare
da72b59
to
1a86858
Compare
_service
(i.e. not spec-compliant subgraphs)subgraph check
on a non-federated graphFixes #121