Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removes unnecessary URL parser #493

Merged
merged 1 commit into from
May 3, 2021
Merged

chore: removes unnecessary URL parser #493

merged 1 commit into from
May 3, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

structopt will use the FromStr implementation provided by the Url crate (src) (which calls Url::parse directly, just like our custom parser was doing, so there's no need for us to have our own function that calls Url::parse!

@EverlastingBugstopper EverlastingBugstopper added this to the May 11 - GA milestone Apr 30, 2021
lrlna
lrlna approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less custom parsers, less problems! LGTM

@EverlastingBugstopper EverlastingBugstopper merged commit f4b16e8 into main May 3, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/remove-unnecessary-parser branch May 3, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrlna lrlna lrlna approved these changes

@JakeDawkins JakeDawkins JakeDawkins approved these changes

Assignees
No one assigned
Labels
maintenance 🛠️
Projects
None yet
Milestone
May 11 - GA
Development

Successfully merging this pull request may close these issues.
3 participants
@EverlastingBugstopper @lrlna @JakeDawkins