Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra new lines to descriptor formatting #533

Merged
merged 6 commits into from
May 11, 2021
Merged

add extra new lines to descriptor formatting #533

merged 6 commits into from
May 11, 2021

Conversation

lrlna
Copy link
Member

@lrlna lrlna commented May 11, 2021

  1. adds extra new lines to all descriptors, i.e.
Fetching SDL from rover-adventure@current using credentials from the adventure profile.
SDL:

type Cat {
  id: ID!
  name: String
}

type Query {
  cat(id: ID!): Cat
  cats: [Cat]
}
  1. Schema Hash descriptor and the actual schema hash are one lined (screenshot at the bottom).
  2. Adds an extra white space after triangle when displaying graph publish diff, as it was very much overlapping.
    image

@lrlna lrlna added the fix 🩹 fixes a bug label May 11, 2021
@lrlna lrlna added this to the May 11 - GA milestone May 11, 2021
@lrlna lrlna merged commit c22822f into main May 11, 2021
@lrlna lrlna deleted the lrlna/rover-482 branch May 11, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants