Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't squash request errors #574

Merged
merged 2 commits into from
May 27, 2021
Merged

fix: don't squash request errors #574

merged 2 commits into from
May 27, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

fixes #539 and #573

An .error_for_status()? was erroneously added to rover-client which bypassed some nicer error handling that we had set up.

@EverlastingBugstopper EverlastingBugstopper added the fix 🩹 fixes a bug label May 25, 2021
@EverlastingBugstopper EverlastingBugstopper added this to the June 8 milestone May 25, 2021
@EverlastingBugstopper EverlastingBugstopper modified the milestones: June 8, May 27 May 27, 2021
@EverlastingBugstopper EverlastingBugstopper merged commit a7c8d97 into main May 27, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/better-subgraph-introspect-error branch May 27, 2021 19:41
@EverlastingBugstopper EverlastingBugstopper mentioned this pull request May 27, 2021
Merged
@lrlna
Copy link
Member

lrlna commented Jun 7, 2021

I am wondering if for #539 and #573 we should add a specific error message suggesting that users might need to introspect a graph instead of a subgraph. It seems like there is some confusion as to which command to use exactly.

@EverlastingBugstopper
Copy link
Contributor Author

We do already!

We return this error, which maps to this suggestion

@EverlastingBugstopper EverlastingBugstopper modified the milestones: May 27, June 8 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrlna lrlna Awaiting requested review from lrlna

Assignees
No one assigned
Labels
fix 🩹 fixes a bug
Projects
None yet
Milestone
June 8
Development

Successfully merging this pull request may close these issues.

Fails with 400 bad request
2 participants
@EverlastingBugstopper @lrlna