chore: re-use same instance of reqwest::blocking::Client & add brotli support
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows us to take advantage of reqwest's ability to re-use connections. Their [docs](https://docs.rs/reqwest/0.11.4/reqwest/blocking/struct.Client.html) explain that you should reuse a client by cloning it to take advantage of its internal connection pool.
abernix
approved these changes
Jul 2, 2021
| self.client.clone() | ||
| } | ||
|
|
||
| pub fn get_authenticated_client(&self, profile_name: &str) -> Result<StudioClient> { |
There was a problem hiding this comment.
This is a more appropriate name, too!
Comment on lines
+8
to
+9
| .gzip(true) | ||
| .brotli(true) |
There was a problem hiding this comment.
Just for posterity, I wanted to make sure this uses the appropriate headers when determining whether or not it attempts the decompression, and indeed it does according to the docs.
EverlastingBugstopper
added a commit
that referenced
this pull request
Jul 2, 2021
…li support (#650) This change allows us to take advantage of reqwest's ability to re-use connections. Their [docs](https://docs.rs/reqwest/0.11.4/reqwest/blocking/struct.Client.html) explain that you should reuse a client by cloning it to take advantage of its internal connection pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to take advantage of reqwest's ability to re-use connections. Their docs explain that you should reuse a client by cloning it to take advantage of its internal connection pool.
It additionally adds the ability to decrompress any responses that are brotli compressed. I imagine there's at least one GraphQL server out there that will need that capability and the cost of adding support is minimal.