chore: adds graphql linter #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
EverlastingBugstopper
added a commit
that referenced
this pull request
Jul 26, 2021
* chore: refactor subgraph check This commit does a lot of heavy lifting for the pending rebase. 1) Creates new input and output types in rover-client for subgraph check 2) Moves GitContext out of rover::utils to rover-client::utils 3) Creates error code E029 for composition errors 4) Styles cloud-composition errors like harmonizer * chore: refactor subgraph fetch (#575) * chore: refactor subgraph publish (#630) * chore: refactor config whoami (#633) * chore: refactor subgraph delete (#639) * chore: refactor subgraph list (#640) * chore: refactor subgraph introspect (#641) * chore: refactor graph introspect (#643) * chore: refactor release update checker (#646) * chore: begin adding shared types and consolidate check operations (#652) * chore: move GraphRef to rover-client (#664) * chore: refactor the rest of rover-client (#675) * chore: do not re-export queries * chore: finish wiring OperationCheck error * chore: adds graphql linter (#677) * fix: graph_ref -> graphref * feat: structured output (#676)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few mistakes during my refactor that were not caught by Rust's
graphql-client. I didn't quite trust myself to find all of the mistakes I made since I was just sorta running into them at runtime (scary!), so I set up a proper GraphQL linter and added it to ourcargo xtask lintjob. This helped me find all of the errors that I made and allowed me to fix them and have confidence that any future changes will be caught by this extra bit of process.I considered adding this to the
build.rsinrover-client, but the scaffolding I have inxtaskjust makes it so much easier.