Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates harmonizer to v0.30.0 #832

Merged
merged 10 commits into from
Sep 24, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

fixes #801 by updating harmonizer to v0.30.0, which is a breaking change for folks using rover supergraph compose with versions of @apollo/gateway < v0.39.0. This is reflected in the docs and will also be called out in our changelog.

cc @StephenBarlow for docs wording/structure review

cc @trevor-scheer for content review

cc @abernix for rubber stamp

cc @prasek because supergraph-demo fails to compose with this version bump.

@EverlastingBugstopper EverlastingBugstopper added this to the v0.3.0 milestone Sep 20, 2021
@EverlastingBugstopper EverlastingBugstopper added BREAKING ❗ a PR that represents a breaking change feature 🎉 new commands, flags, functionality, and improved error messages labels Sep 20, 2021
docs/source/supergraphs.md Outdated Show resolved Hide resolved
docs/source/supergraphs.md Outdated Show resolved Hide resolved
@EverlastingBugstopper EverlastingBugstopper self-assigned this Sep 20, 2021
Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! (reviewed docs content only)

docs/source/supergraphs.md Outdated Show resolved Hide resolved
@EverlastingBugstopper
Copy link
Contributor Author

Thanks @abernix - I like what you wrote quite a bit more than what I wrote!

@EverlastingBugstopper
Copy link
Contributor Author

@abernix I've added a section to the docs calling out additional requirements for the @tag directive that were called out in the changelog here and satisfied in this supergraph-demo PR.

@trevor-scheer was helpful here and noted that this is just a temporary breaking change and future versions will not have these additional requirements

@trevor-scheer
Copy link
Member

Unbreak will happen via this PR: apollographql/federation#1022

@EverlastingBugstopper
Copy link
Contributor Author

confirmation that this works with the trevor/update-tags-ref branch on supergraph-demo:

$ cargo xtask integration-test --branch trevor/update-tag-defs
    Finished dev [unoptimized + debuginfo] target(s) in 0.08s
     Running `target/debug/xtask integration-test --branch trevor/update-tag-defs`
info: running `cargo build --target x86_64-unknown-linux-gnu` in `/home/avery/work/rover`
info: successfully compiled to `/home/avery/work/rover/target/x86_64-unknown-linux-gnu/debug/rover`
info: running `git clone https://github.com/apollographql/supergraph-demo --branch trevor/update-tag-defs` in `/tmp/.tmpbdZhRE`
info: running `make ci` in `/tmp/.tmpbdZhRE/supergraph-demo`
info: successfully ran supergraph-demo with a local binary.
Success!

@EverlastingBugstopper
Copy link
Contributor Author

Labelled this as blocked until we resolve the @tag repeatable breaking change that could be solved by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING ❗ a PR that represents a breaking change feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update harmonizer (breaking change)
4 participants