Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds rover graph delete #861

Merged
merged 6 commits into from
Oct 25, 2021
Merged

Conversation

EverlastingBugstopper
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper commented Oct 5, 2021

starts to fix #722 by adding the rover graph delete command.

rover graph delete allows you to delete a single variant from your graph.
It will never fully delete the graph, only the specified variant.

If you delete all the variants from a graph, you still retain ownership over the graph ref and graph title, and it will show in Studio as an "unconfigured" graph:

image

This PR also updates quite a few error messages to make them more clear, and handles a few more cases than it did previously, taking in some work I had on a local branch for #729

TODO:

  • Don't require --convert for subgraph publish on a variant with no schema
  • Print [y/N] prompt on graph delete
  • Add --confirm flag to bypass [y/N] prompt
  • Update the docs for graph provisioning

@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/graph-delete branch 2 times, most recently from 7c24d63 to edae344 Compare October 6, 2021 20:04
@EverlastingBugstopper EverlastingBugstopper added this to the 0.4.0 milestone Oct 19, 2021
@EverlastingBugstopper EverlastingBugstopper added docs 📝 improvements or additions to docs on the docs site feature 🎉 new commands, flags, functionality, and improved error messages labels Oct 19, 2021
@EverlastingBugstopper EverlastingBugstopper force-pushed the avery/graph-delete branch 2 times, most recently from 406922d to 30f7ac2 Compare October 19, 2021 17:54
`rover graph delete` allows you to delete a single variant from your graph.
It will never fully delete the graph, only the containing variants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs 📝 improvements or additions to docs on the docs site feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create/Delete graph variants using Rover CLI
2 participants