update storybook stories to use <option value="">

apollographql · Nov 24, 2020 · dcc9cf5 · dcc9cf5
1 parent 941ae2c
commit dcc9cf5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/Select/Select.story.mdx b/src/Select/Select.story.mdx
@@ -62,7 +62,8 @@ You must use the same `<option>` and `<optgroup>` elements you would use for a n
     />
   </Story>
   <Story name="basic optgroup">
-    <Select label={<>select an item</>}>
+    <Select>
+      <option value="">select an item</option>
       <optgroup label="Group of options">
         <option value="value a">a</option>
         <option value="value b">b</option>
@@ -74,7 +75,8 @@ You must use the same `<option>` and `<optgroup>` elements you would use for a n
     </Select>
   </Story>
   <Story name="disabled">
-    <Select label="disabled" disabled>
+    <Select disabled>
+      <option value="">select an item</option>
       <option value="value a">a</option>
       <option value="value b">b</option>
     </Select>
@@ -97,15 +99,17 @@ Selects can be displayed using any of the `feel` values from `Button`.
 
 <Canvas>
   <Story name="feel raised">
-    <Select label={<>select an item</>} feel="raised">
+    <Select feel="raised">
+      <option value="">select an item</option>
       <option>a</option>
       <optgroup label="header 1">
         <option>b</option>
       </optgroup>
     </Select>
   </Story>
   <Story name="feel flat">
-    <Select label={<>select an item</>} feel="flat">
+    <Select feel="flat">
+      <option value="">select an item</option>
       <option>a</option>
       <optgroup label="header 1">
         <option>b</option>

diff --git a/src/Select/index.tsx b/src/Select/index.tsx
@@ -153,7 +153,7 @@ interface Props
 
 export const Select: React.FC<Props> = ({
   children,
-  initialValue,
+  initialValue = "",
   disabled = false,
   feel,
   labelPropsCallbackRef,