AP-919 Stop propagation of clicks when disabled using input as #122

jgzuke · 2019-10-02T00:10:20Z

First add a failing test for the case when using as={<div ... >}. The other test uses as= but passes a button so the disabled prop already works as intended.
Uncomment the line that fixes the test

src/Button/Button.spec.tsx

apollo-bot2 · 2019-10-03T00:20:55Z

🚀 PR was released in v2.12.0 🚀

jgzuke added 2 commits October 1, 2019 17:07

Add failing test

f999eee

When disabled stop event propogation-of-clicks

b033733

jgzuke added the minor Increment the minor version when merged label Oct 2, 2019

justinanastos self-requested a review October 2, 2019 17:33

justinanastos suggested changes Oct 2, 2019

View reviewed changes

src/Button/Button.spec.tsx Outdated Show resolved Hide resolved

Change test name

85cf6c1

jgzuke requested a review from justinanastos October 2, 2019 17:56

justinanastos approved these changes Oct 2, 2019

View reviewed changes

jgzuke merged commit ebb0ab0 into master Oct 3, 2019

apollo-bot2 added the released This issue/pull request has been released. label Oct 3, 2019

Provide feedback