This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Change loader spin duration to 750ms #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
approved these changes
Nov 19, 2019
src/Loaders/LoadingSpinner.tsx
Outdated
Comment on lines
29
to
30
| // Length of animation | ||
| const DURATION = 750; |
There was a problem hiding this comment.
NBD/minor: I know that it's commonly held to be a good idea to store constants instead of using magic numbers; but I prefer to at least keep them in the same function so the function has fewer external dependencies, and just so I don't have to go looking around for things. Also, use jsdoc style comments so that we get hinting from vs code elsewhere (meaning /** Length of animation */ instead of // )
|
🚀 PR was released in v2.17.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the loader spin duration from 540ms to 750ms
540ms (current) https://share.getcloudapp.com/wbue4ejW
750ms https://share.getcloudapp.com/X6u21YZX
1000ms https://share.getcloudapp.com/JruwRwk1