This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Add address icon #152
Merged
Add address icon #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheapsteak
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
If we're likely to use this icon in a place where it's not indicating an address then IconBuilding is better.
If we're likely to change the address icon to something else that's not a building then IconAddress is convenient (everywhere that uses this will update automatically when they upgrade without having to change their imports)
I usually veer towards a more conservative approach for shared packages, but this is also probably fine
|
I think the first scenario is more likely, will switch to icon-building 👍 |
jgzuke
force-pushed
the
jgzuke/add-address-icon
branch
from
82e55d5
to
d62ffa4
Compare
|
🚀 PR was released in v2.23.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an address icon, needed for https://app.zeplin.io/project/5d375cd742170577784b28ca/screen/5e18bfcefab44daa8e3eded6.
This could be icon-building too? We seem to have a mix of things named for what the icon is and what is does/is used for