This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AP-1335 Fix animations not being disabled by SpaceKitProvider
#155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheapsteak
approved these changes
Feb 6, 2020
justinanastos
changed the title
SpaceKitProviderSpaceKitProvider
|
Going to reset reviews because I found a better way to disable animations that will make the library behave as one would expect in tests so we can test both menus/tooltips appearing and disappearing. |
justinanastos
force-pushed
the
justin/AP-1335/menus
branch
from
efaba76 to
e5c2118
Compare
justinanastos
changed the title
SpaceKitProviderSpaceKitProvider
|
🚀 PR was released in v2.25.1 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animations are still happening causing flake in our tests. It appears as though settinganimationtoundefinedcauses the default ofshift-awayto be used. We can use an empty string instead to disable animations.The above approach is hacky. While it visually works; it is hacky and is tricking tippy.js to do something that's already natively supported.
Instead, we should set
durationto0andupdateDurationto0, and then tippy.js will recognize we're not animating. This will show the same visual output as before, but this has the additional benefit of disabling animation behaviors in the codebase that tripped us up in our JSDOM tests. Now we can test that tooltips appear and then disappear. Since there's no more delays for animations, now rendering and clicking things acts closer to synchronous, allowing our tests to be more succinct and faster!Contributes to https://apollographql.atlassian.net/browse/AP-1335