This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AP-1393 Add endIcon prop to Button
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/button-end-icon
branch
from
c72bac7
to
08b1dd6
Compare
justinanastos
changed the title
endIcon prop to ButtonendIcon prop to Button
|
Hmm, im not sure what the interaction is like here, but to me these look like selects, not buttons? |
|
🚀 PR was released in v3.1.0 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be useful when when using a button component as a trigger for a dropdown menu
See the new storybook story for how this looks.
https://sketch.cloud/s/eDpdP/v/EL0Yov/a/exWVap/r/PG8AZv
https://apollographql.atlassian.net/browse/AP-1393