You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an operations icon named src/icons/svgs/navigation/icon-operations.svg when we already have src/icons/svgs/navigation/icon-operations-sl.svg. I never planned on having an icon with the same name as -sl; so this causes the library to get confused because when it converts svg files to TypeScript files it uses the filename to make the new filename and strips off -sl. So icon-operations.svg and icon-operations-sl.svg will both be read and will output the same filename, causing an overwrite. Then storybook will look at the source .svg files because it needs to know if an svg is a streamline icon or not, which is why we see the same icon on there twice.
TLDR; Delete src/icons/svgs/navigation/icon-operations-sl.svg in this PR and you'll be all set.
I should add a test that verifies that there aren't duplicates so that we know exactly why things are behaving strangely strange.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
minorIncrement the minor version when mergedreleasedThis issue/pull request has been released.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding this icon
