This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
darken spinner trail by 1 shade #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglovier
approved these changes
Jun 26, 2020
jgzuke
approved these changes
Jun 26, 2020
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pages in Studio now have grey-light backgrounds, and the orbit blends in to the background
Making the orbit a shade darker for the "light" theme would solve this problem
It does change the orbit trail color for an existing theme so it's a breaking change; however this seemed more pragmatic than creating a different theme name to call this
Longer term if we revist the component's api, we should consider passing the 2 colors we're using in via props (e.g. fgColor, bgColor) so we would require a version bump and package update to change colors (cui bono?)