Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Show focus on Button when interacting with keyboard #244

Merged
merged 5 commits into from
Oct 19, 2020
Merged

Show focus on Button when interacting with keyboard #244

merged 5 commits into from
Oct 19, 2020

Commits on Oct 19, 2020

  1. ➕ add @react-aria/focus and @react-aria/utils

    @justinanastos
    justinanastos committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    c8edeaa View commit details
    Browse the repository at this point in the history

  2. ♻️ refactor Button to use @react-aria/focus useFocusRing 

    This will _appear_ the same as before, but now the behavior is closer to
correct. Before when a user clicked, we would blur the button to not show
it's focused style. This was wrong for accessiblity because when a button
is clicked, it should retain the focus to allow tabbing. Now we use
`@react-aria/focus` to show the focus style if the user arrived on the
element with the keyboard only.
    @justinanastos
    justinanastos committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    6da0d9f View commit details
    Browse the repository at this point in the history

  3. ➕ add lodash

    @justinanastos
    justinanastos committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    b4f4c1a View commit details
    Browse the repository at this point in the history

  4. ✅ add test to Button to ensure className props are merged when usin… 

    …g as
    @justinanastos
    justinanastos committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    5957483 View commit details
    Browse the repository at this point in the history

  5. ✨ use @react-aria/utils's mergeProps in Button 

    This does the things we're doing by hand automatically.
    @justinanastos
    justinanastos committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    04f902a View commit details
    Browse the repository at this point in the history