Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Remove extra top margin for TextField error #246

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Remove extra top margin for TextField error #246

merged 1 commit into from
Oct 29, 2020

Conversation

Jephuff
Copy link
Contributor

@Jephuff Jephuff commented Oct 20, 2020 •
edited by apollo-bot2
Loading

The child of this div also defines the same top margin so this won't affect the spacing.
The margin made it so the TextField would have a bottom margin when theres no error and no bottom margin if there was an error (or helper)

I needed some things to bottom align, so I had to override https://github.com/mdg-private/studio-ui/pull/3309/files#diff-9749735bbcd698b22a14d33a71362ee7c8d94da4725bd333a5fad713218412e2R341

I'm marking this as a major version cause I'll have to go through all the TextFields to make sure they are still spaced correctly.

📦 Published PR as canary version: 7.21.1-canary.246.5970.0

✨ Test out this PR locally via:

npm install @apollo/space-kit@7.21.1-canary.246.5970.0
# or 
yarn add @apollo/space-kit@7.21.1-canary.246.5970.0

@Jephuff Jephuff added the major Increment the major version when merged label Oct 20, 2020
@Jephuff Jephuff requested a review from a team October 20, 2020 20:42
jglovier
jglovier approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@jglovier jglovier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 🚢 ✨

@justinanastos justinanastos added the skip-release Preserve the current version when merged label Oct 29, 2020
@justinanastos justinanastos merged commit b6384dc into main Oct 29, 2020
@justinanastos justinanastos deleted the jeffrey/remove-extra-top-margin branch October 29, 2020 17:50
@apollo-bot2
Copy link
Collaborator

🚀 PR was released in v8.0.0 🚀

@apollo-bot2 apollo-bot2 added the released This issue/pull request has been released. label Oct 29, 2020
justinanastos added a commit that referenced this pull request Oct 29, 2020
@justinanastos
Revert "Merge pull request #246 from apollographql/jeffrey/remove-ext…
080ab57 
…ra-top-margin"

This reverts commit b6384dc, reversing
changes made to 7a26928.
@justinanastos justinanastos mentioned this pull request Oct 29, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jglovier jglovier jglovier approved these changes

Assignees
No one assigned
Labels
major Increment the major version when merged released This issue/pull request has been released. skip-release Preserve the current version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jephuff @apollo-bot2 @jglovier @justinanastos