This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AR-1935 Reset Button css outline
#255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently changed the logic for displaying outlines on
Buttons from using:focusin css in conjunction with callingblur()after clicking on a button to remove the focus to usinguseFocusRingfromreact-aria. The new logic no longer does anything with:focus { outline: ... }. This causes any side-wide focus styles to now be applied to our buttons.Remove the outline in css because we're controlling it internally now.
Resolves AR-1935
📦 Published PR as canary version:
8.0.1-canary.255.6098.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.0.1-canary.255.6098.0 # or yarn add @apollo/space-kit@8.0.1-canary.255.6098.0