Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

Dont warn whenever using controlled version of component #284

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Dont warn whenever using controlled version of component #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d061086
Dont warn whenever using controlled version of component
Dec 8, 2020
b9cf09d
Merge branch 'main' into jgzuke/misc/fix-select-initial-value
Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Select/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ interface Props

export const Select: React.FC<Props> = ({
children,
initialValue = "",
initialValue,
disabled = false,
feel,
labelPropsCallbackRef,
Expand All @@ -156,7 +156,7 @@ export const Select: React.FC<Props> = ({
...props
}) => {
const [uncontrolledValue, setUncontrolledValue] = React.useState(
initialValue
initialValue ?? ""
);

// Validate controlled versus uncontrolled
Expand Down