This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Tighten up card drop shadow #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The card component's default drop shadow is a bit excessive, like to the point of distracting when there are multiple cards stacked closely together on a page like we have in several views (graph index, integrations, settings, etc). This PR tweaks the shadow just a tiny bit to help make it a bit more subtle.
Drop shadows are helpful to convey depth, and depth is helpful to convey content hierarchy via z-index, or simply visual interest. In this case, we get plenty of the hierarchy and associative grouping simply from the card itself being lighter than page background, and the card border. The shadow does help bring some sense of the visual metaphor, but it doesn't need to be quite as pronounced as it is.
Note: I used a version like this on my design mocks for the cards on the Schema L2s and it got implemented that way there.
📦 Published PR as canary version:
8.9.0-canary.295.7387.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.9.0-canary.295.7387.0 # or yarn add @apollo/space-kit@8.9.0-canary.295.7387.0