This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Finally fix Tooltip pixel shifting #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
requested review from
cheapsteak,
Jephuff,
jgzuke and
timbotnik
cheapsteak
approved these changes
Jan 25, 2021
|
@cheapsteak I think I was wrong; This won't negatively affect us but I don't think this, or the other attempt I sent in, will fix it. I think this is an underlying popper issue that I will continue to be super annoyed for the time being. While I want to just delete these stories; these cause problems downstream too, so I'd love to find a root cause. |
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this will finally stop the single-pixel flipping of Tooltips, ConfirmationTooltips, and Menus. I am able to reproduce the pixel shifting post-animation reliably in storybook, this should get rid of it.
📦 Published PR as canary version:
8.11.1-canary.301.7634.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.11.1-canary.301.7634.0 # or yarn add @apollo/space-kit@8.11.1-canary.301.7634.0