This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AR-2064 Resolve issue where ListDivider overflows container
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/fix-list-divider
branch
from
7b29579
to
0036c53
Compare
justinanastos
changed the title
ListDivider overflows containerListDivider overflows container
cheapsteak
approved these changes
Feb 11, 2021
|
Thanks - I will delete the studio UI overflow bit on the PR for the FeatureIntro feature! |
mayakoneval
approved these changes
Feb 11, 2021
This causes the list to scroll side-to-side. Resolved by absolutely positioning the `hr` so that it doesn't have any effect on scroll behavior.
justinanastos
force-pushed
the
justin/fix-list-divider
branch
from
0036c53
to
af8b0a5
Compare
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AR-2064
The overflowing
ListDividercausedListto horizontally scroll. There was a fix in place in Studio UI; but that breaks the ability to nest tooltips. This resolves the root issue by absolutely positioning thehrinListDividerso it no longer is considered for scroll behavior.Testing
You can see the wrong behavior here. Visit this story, try to scroll horizontally. You'll see it's possible, but it shouldn't be.
You can verify the correct behavior in the deploy preview here.
📦 Published PR as canary version:
8.14.1-canary.312.8165.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.14.1-canary.312.8165.0 # or yarn add @apollo/space-kit@8.14.1-canary.312.8165.0