-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
@fmvfelipemonsalve do you mind if I add a commit to delete the left padding on the first column and the right padding on the last child? I noticed this is inconsistent with the designs we have for tables and I would like to slip it in here |
@mayakoneval Go for it. I did notice that, but didn't think it was important. I might need to make slight adjustments to the service tag tables after this, so let me know when you do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's talk about the changes I suggested! My goal is not just to keep this project easy to use but also to get you to think the same way :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments!
b623020
to
b715f62
Compare
b715f62
to
8de1adc
Compare
b7249f7
to
1e150d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fmvfelipemonsalve I might have messed something up when I pushed, but I see the old Table.tsx
(src/Table.tsx
rather than src/Table/Table.tsx
) in the commits, so we should delete that if you think everything else is okay.
I also think we should definitely add a storybook showing a table that is configured with special column widths / spans something.
I added a commit to make the first column have no left padding and last column to have to right padding. Thoughts?
My guess is you were working on an old branch, since I saw the old file yesterday and removed it. Will force push again to fix the branch (with your commit on top), and you can pull. Sounds good? |
1e150d2
to
90aa02f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love this! Almost there!
Please update the changelog too!
…ied to specific columns
90aa02f
to
d0f241c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
76178c0
to
2f12845
Compare
AP-539
This adds ability to set column widths for tables, plus added the loading state as spacified in the design spec. I made this modifications so I could finish AP-539.