Skip to content
This repository has been archived by the owner on Jan 20, 2022. It is now read-only.

AR-2127 fix FormErrorMessage not being removed when errors disappear #324

Merged
merged 5 commits into from
Mar 1, 2021

Conversation

justinanastos
Copy link
Contributor

@justinanastos justinanastos commented Mar 1, 2021

AR-2127

Added a failing test to verify the issue and the new code fixes the error.

📦 Published PR as canary version: 8.17.1-canary.324.8574.0

✨ Test out this PR locally via:

npm install @apollo/space-kit@8.17.1-canary.324.8574.0
# or 
yarn add @apollo/space-kit@8.17.1-canary.324.8574.0

@justinanastos justinanastos added the bug fix Increment the patch version when merged label Mar 1, 2021
Copy link
Contributor

@mayakoneval mayakoneval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@justinanastos justinanastos merged commit 0e42c3b into main Mar 1, 2021
@justinanastos justinanastos deleted the justin/AR-2127/form-error-message branch March 1, 2021 20:40
@apollo-bot2
Copy link
Collaborator

🚀 PR was released in v8.17.1 🚀

@apollo-bot2 apollo-bot2 added the released This issue/pull request has been released. label Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants