This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AR-2129 Allow all form control children to be removed on subsequent renders #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/AR-2129/remove-all-form-controls-possible
branch
from
c181d6f
to
dbe629d
Compare
justinanastos
force-pushed
the
justin/AR-2129/remove-all-form-controls-possible
branch
from
dbe629d
to
5510fc4
Compare
justinanastos
changed the title
justinanastos
deleted the
justin/AR-2129/remove-all-form-controls-possible
branch
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AR-2129
I should have done this with AR-2127, but I was lazy. This will cover all of the components and make a single test to capture all of them using
test.each.📦 Published PR as canary version:
8.17.2-canary.325.8623.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.17.2-canary.325.8623.0 # or yarn add @apollo/space-kit@8.17.2-canary.325.8623.0