This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Expose color prop for elect trigger #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
approved these changes
Mar 12, 2021
Co-authored-by: Justin Anastos <justin@apollographql.com>
Co-authored-by: Justin Anastos <justin@apollographql.com>
jgzuke
force-pushed
the
jgzuke/misc/allow-setting-trigger-color
branch
from
a0dec56
to
de35631
Compare
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personally I find in unintuitive that the
color,feel,size, etc passed on thetriggerAsget overwritten. I went with this as the smallest unblocking change, but also happy to switch this to follow props passed totriggerAsso we dont need a mix of top level props andtriggerAsto style a custom trigger.📦 Published PR as canary version:
8.18.1-canary.326.8945.0✨ Test out this PR locally via:
npm install @apollo/space-kit@8.18.1-canary.326.8945.0 # or yarn add @apollo/space-kit@8.18.1-canary.326.8945.0